Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoPkg/BaseCryptLib: Add additional RSAES-OAEP crypto functions #78

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

makubacki
Copy link
Member

@makubacki makubacki commented Mar 21, 2024

Description

Expand the availability of the RSAES-OAEP crypto capability in
BaseCryptLib. Applications using RSA crypto functions directly from
OpensslLib can transition to BaseCryptLib to take advantage of the
shared crypto feature in CryptoDxe.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Host-based unit tests, end-to-end testing with shared crypto binary.

Integration Instructions

When picking up the crypto binary built with this change, you must
include commit 6cc02e2 from the release/202311 branch in Mu
Basecore.

Chris Ruffin and others added 3 commits March 21, 2024 18:57
Expand the availability of the RSAES-OAEP crypto capability in
BaseCryptLib.  Applications using RSA crypto functions directly from
OpensslLib can transition to BaseCryptLib to take advantage of the
shared crypto feature in CryptoDxe.

Pkcs1v2Decrypt(): decryption using DER-encoded private key, converse of Pkcs1v2Encrypt()
RsaOaepEncrypt(): encryption using RSA contexts created with RsaNew()/RsaSetKey()
RsaOaepDecrypt(): decryption using RSA contexts created with RsaNew()/RsaSetKey()
@makubacki makubacki requested review from kenlautner and apop5 March 21, 2024 23:02
@makubacki makubacki self-assigned this Mar 21, 2024
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact impact:security Has a security impact impact:testing Affects testing labels Mar 21, 2024
@makubacki makubacki changed the title Cmruffin rsaoaep 202311 CryptoPkg/BaseCryptLib: Add additional RSAES-OAEP crypto functions Mar 21, 2024
@makubacki
Copy link
Member Author

makubacki commented Mar 21, 2024

NOTE: This is a version of the previously reviewed PR (#74) that targets MU_BASECORE release/202311.

Attn: @cmruffin

@makubacki makubacki merged commit 133b733 into microsoft:release/202311 Mar 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:security Has a security impact impact:testing Affects testing language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants