Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MSAL and Azure Identity dependency versions #2584

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Jan 14, 2025

Updated the pom.xml with the latest versions of MSAL and Azure Identity.

The project's public Azure Artifact feed is also updated with the latest versions of MSAL and Azure Identity.

To test locally, pull this branch and do a fresh local build with mvn clean install -DskipTests -T 1C. If it works, your local build run should complete successfully without errors.

Search for Update Public Azure Artifacts Feed in the internal driver docs (not public) to learn more.

Jeffery-Wasty
Jeffery-Wasty previously approved these changes Jan 14, 2025
Copy link
Contributor

@lilgreenbird lilgreenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also later versions of antlr-runtime, com.google.code.gson, bcprov-jdk18on, bcpkix-jdk18on, junit-jupiter, hikaricp, gremini.mock, h2
please check all dependencies and update to latest stable release versions

@lilgreenbird lilgreenbird added this to the 12.10.0 milestone Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.14%. Comparing base (5bb3353) to head (4112e70).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2584      +/-   ##
============================================
- Coverage     51.01%   50.14%   -0.88%     
+ Complexity     3921     3898      -23     
============================================
  Files           147      147              
  Lines         33483    33483              
  Branches       5609     5609              
============================================
- Hits          17081    16789     -292     
- Misses        13991    14358     +367     
+ Partials       2411     2336      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jeffery-Wasty
Jeffery-Wasty previously approved these changes Jan 21, 2025
David-Engel
David-Engel previously approved these changes Jan 23, 2025
lilgreenbird
lilgreenbird previously approved these changes Jan 24, 2025
@lilgreenbird
Copy link
Contributor

this is currently on hold as MSAL 1.17.2 has a vulnerability. We need to wait for azure-identity to move to a later version so we can update to latest for both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under Peer Review
Development

Successfully merging this pull request may close these issues.

4 participants