Add Delay Send API Flag #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
commented
Nov 12, 2020
anrossi
reviewed
Nov 12, 2020
anrossi
reviewed
Nov 12, 2020
|
Based on a suggestion from .NET, I feel like allowing a 0 length send with the flush flag is a good idea to add. A method to explicitly flush without checking that you're at the end of your data actively while looping is a good idea to have, especially for high level wrappers. Not worth adding a new API to do in C, especially if we could just plumb 0 length send to work. |
ThadHouse
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new API send flag for StreamSend that allows the app to indicate that the send shouldn't be done immediately. This is meant to be used as a hint to QUIC to indicate "more is coming". This allows the app to control the amount of "send batching" that occurs at the QUIC/UDP layer.