Delegate build environment configuration with QUIC_EXTERNAL_TOOLCHAIN #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4625 +/- ##
==========================================
- Coverage 86.93% 86.69% -0.25%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15087 15045 -42
- Misses 2267 2309 +42 ☔ View full report in Codecov by Sentry. |
redbaron
force-pushed
the
gamecore-cmake
branch
from
279407b to
b59365c
Compare
Well managed CMake build environments make use of CMAKE_TOOLCHAIN_FILE to configure build environment such as include/lib search paths, system libraries, build flags, etc. This change introduces QUIC_EXTERNAL_TOOLCHAIN build option, which when enabled stops MSQuic CMake scripts from attempting to do CMake toolchain job. QUIC_EXTERNAL_TOOLCHAIN defaults to OFF to preserve original behaviour.
redbaron
force-pushed
the
gamecore-cmake
branch
from
b59365c to
221db9c
Compare
nibanks
approved these changes
Oct 25, 2024
nibanks
pushed a commit
that referenced
this pull request
Dec 4, 2024
…#4625) Well managed CMake build environments make use of CMAKE_TOOLCHAIN_FILE to configure build environment such as include/lib search paths, system libraries, build flags, etc. This change introduces QUIC_EXTERNAL_TOOLCHAIN build option, which when enabled stops MSQuic CMake scripts from attempting to do CMake toolchain job. QUIC_EXTERNAL_TOOLCHAIN defaults to OFF to preserve original behaviour.
Closed
talregev
pushed a commit
to talregev/msquic
that referenced
this pull request
Dec 4, 2024
…microsoft#4625) Well managed CMake build environments make use of CMAKE_TOOLCHAIN_FILE to configure build environment such as include/lib search paths, system libraries, build flags, etc. This change introduces QUIC_EXTERNAL_TOOLCHAIN build option, which when enabled stops MSQuic CMake scripts from attempting to do CMake toolchain job. QUIC_EXTERNAL_TOOLCHAIN defaults to OFF to preserve original behaviour.
nibanks
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Change public headers to support msh3 (#4525) * simplify export include dir cmake code (#4575) * Delegate build environment configuration with QUIC_EXTERNAL_TOOLCHAIN (#4625) Well managed CMake build environments make use of CMAKE_TOOLCHAIN_FILE to configure build environment such as include/lib search paths, system libraries, build flags, etc. This change introduces QUIC_EXTERNAL_TOOLCHAIN build option, which when enabled stops MSQuic CMake scripts from attempting to do CMake toolchain job. QUIC_EXTERNAL_TOOLCHAIN defaults to OFF to preserve original behaviour. * export platform (#4574) * Add wbemuuid (#4687) --------- Co-authored-by: Maxim Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well managed CMake build environments make use of CMAKE_TOOLCHAIN_FILE to configure build environment such as include/lib search paths, system libraries, build flags, etc.
This change introduces QUIC_EXTERNAL_TOOLCHAIN build option, which when enabled stops MSQuic CMake scripts from attempting to do CMake toolchain job.
QUIC_EXTERNAL_TOOLCHAIN defaults to OFF to preserve original behaviour.