improve OpenSSL detection during build #3390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up on #3387 (comment)
I changed the check so 3.0.2 would be acceptable when we expect 3.0.
The problem its that if we expect
1.1.1
,3.0
would also work withVERSION_GREATER
.To fix that, I now construct subversion as
1.1
or '3.0' and I use that for comparison as well.The expected
1.1.1
would never match but the3.0
would work as expected.Running "wrong" configure on Ubuntu 22 now produce
To make it somewhat more friendly I also updated the powershelgl build script to try to detect the correct version if no one is specified.
This will not help users like @ManickaP when make is invoked directly, but it should make it easier for general consumers.
Hopefully the error above would make it clear.