Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust apiset fallback for user32 dependencies in WebView2 #7977

Merged

Conversation

brianostms
Copy link
Contributor

Reverse the order of the user32 apiset fallback. If the app had already loaded a user32 forwarder, it was trying to use the wrong module.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 29, 2022
@kmahone
Copy link
Member

kmahone commented Nov 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Nov 29, 2022

It looks like this change resulted in a test failure:
InteractionTests.WebView2Tests.ConcurrentCreationRequestsTest

@brianostms can you take a look? If you think this is an unrelated failure, let me know and I can try re-running the pipeline.

@kmahone
Copy link
Member

kmahone commented Nov 30, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone merged commit 80a4bf4 into microsoft:main Nov 30, 2022
@bpulliam bpulliam removed the needs-triage Issue needs to be triaged by the area owners label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants