Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebView2 should cache input state #7575

Merged
merged 1 commit into from
Aug 11, 2022
Merged

WebView2 should cache input state #7575

merged 1 commit into from
Aug 11, 2022

Conversation

krschau
Copy link
Contributor

@krschau krschau commented Aug 8, 2022

This change undoes part of #7555.
We can't rely on PointerUpdateKind, because WinRT does not pass all relevant events, and we don't have balanced Pressed/Released button presses. We should ensure that events are balanced by keeping track of what button was pressed, and send that message to Core WebView2.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Aug 8, 2022
@krschau
Copy link
Contributor Author

krschau commented Aug 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@DmitriyKomin DmitriyKomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@krschau krschau merged commit cad9cbf into main Aug 11, 2022
@krschau krschau deleted the user/krschau/wv2-putback branch August 11, 2022 22:16
@ghost
Copy link

ghost commented Aug 15, 2022

🎉Microsoft.UI.Xaml v2.8.1 has been released which incorporates this pull request.:tada:

Handy links:

@ranjeshj ranjeshj added team-Rendering Issue for the Rendering team area-WebView and removed needs-triage Issue needs to be triaged by the area owners labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-WebView team-Rendering Issue for the Rendering team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants