Fix WebView2 accessibility crash in ProviderWrapper::GetRuntimeId #7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jevansaks
approved these changes
Jul 8, 2022
krschau
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProviderWrapper::GetRuntimeId used for WebView2 accessibility is reported to be consistently crashing on some machines. From inspection this appears to be due to incorrect lLBounds being passed in:
SAFEARRAY* psa = SafeArrayCreateVector(VT_I4, 1, 2)
lLBounds specifies the lower bound for the safe array and is usually set to 0. Here it is incorrectly set to 1, presumably causing a crash in some environments when we try to set the 0’th index via SafeArrayPutElement a few lines later.
Also added check for possible out-of-memory condition from SafeArrayCreateVector.