Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LandmarkType in InfoBar #6986

Merged
merged 5 commits into from
May 4, 2022
Merged

Fix LandmarkType in InfoBar #6986

merged 5 commits into from
May 4, 2022

Conversation

bkudiess
Copy link
Contributor

Fixes Landmark type in InfoBar:

  • Fix SetLocalizedLandmarkType never being called inside if
  • Sets landmark type to custom
  • Moves landmark from title to grid

Before:
image

After:
image

Fixes internal bug 38393708.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 18, 2022
@bkudiess bkudiess added accessibility Narrator, keyboarding, UIA, etc area-InfoBar area-Accessibility and removed needs-triage Issue needs to be triaged by the area owners labels Apr 18, 2022
@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

marcelwgn
marcelwgn approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm curios if we still need the border element if the internal grid is handling most of the things now.

ranjeshj
ranjeshj reviewed Apr 19, 2022
View reviewed changes
dev/InfoBar/InfoBar.xaml Outdated Show resolved Hide resolved
@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bkudiess
Copy link
Contributor Author

bkudiess commented May 2, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bkudiess
Copy link
Contributor Author

bkudiess commented May 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bkudiess bkudiess merged commit ba45dbd into main May 4, 2022
@bkudiess bkudiess deleted the user/bakudies/infobar-landmark-narrator branch May 4, 2022 18:03
@ghost
Copy link

ghost commented Jun 2, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220601001 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn approved these changes

@ranjeshj ranjeshj ranjeshj approved these changes

Assignees
No one assigned
Labels
accessibility Narrator, keyboarding, UIA, etc area-Accessibility area-InfoBar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkudiess @marcelwgn @ranjeshj