Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HyperlinkButton height #6970

Merged
merged 1 commit into from Jun 30, 2022
Merged

Fix HyperlinkButton height #6970

merged 1 commit into from Jun 30, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2022

HyperlinkButton has a transparent 1px border which made it look smaller than other buttons (30px vs 32px). It is now using OuterBorderEdge.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 14, 2022
@ojhad ojhad added team-Controls Issue for the Controls team area-HyperlinkButton and removed needs-triage Issue needs to be triaged by the area owners labels Apr 19, 2022
@kmahone
Copy link
Member

kmahone commented May 23, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented May 23, 2022

@dansmor7 thanks for submitting this change. Could you help me understand the problem that you are aiming to solve here? Screenshots from before and after would be helpful.
Thanks!

@ghost
Copy link
Author

ghost commented Jun 29, 2022

image
image

The HyperlinkButton appears smaller than the Button because it has a transparent border.
I fixed this by changing BackgroundSizing, but it might not be the best solution.
Would it be better to set the border thickness to 0?

@kmahone
Copy link
Member

kmahone commented Jun 30, 2022

Thanks, I understand what you mean now.

@kmahone
Copy link
Member

kmahone commented Jun 30, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone merged commit 25bcb7a into microsoft:main Jun 30, 2022
@kmahone
Copy link
Member

kmahone commented Jun 30, 2022

Thanks for contributing this fix @dansmor7

@ghost ghost deleted the hyperlink-height-fix branch October 5, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-HyperlinkButton team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants