Fixing AppBarButton visual state overlap #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Apr 5, 2022
llongley
added
area-Commanding
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kmahone
pushed a commit
that referenced
this pull request
Apr 6, 2022
Following 664933b we ran into the issue that we now have two different visual state groups targeting the same property (SubItemChevron.Margin), which can cause problems in that one can pave over the other. I've fixed things by duplicating the SubItemChevron so the states for buttons in the primary and secondary items can be managed separately from each other, and toggled visibility of the two based on where the button is located. Also added an automated API test that reproduces the issue without the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this change, we ran into the issue that we now have two different visual state groups targeting the same property (SubItemChevron.Margin), which can cause problems in that one can pave over the other. I've fixed things by duplicating the SubItemChevron so the states for buttons in the primary and secondary items can be managed separately from each other, and toggled visibility of the two based on where the button is located.
Also added an automated API test that reproduces the issue without the fix.