Fix TeachingTip getting stuck closed #6541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void getting into a state where the tip isn't being displaced despite IsOpen being true.
ghost
added
the
StephenLPeters
changed the title
StephenLPeters
added
area-TeachingTip
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…is not interactable.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Feb 23, 2022
2 tasks
|
@StephenLPeters Can we expect this to land in WinAppSDK 1.1 ?
What do you mean by programmatically close? I don't see any other API to close a teaching tip. Or is it a note to self? Also, I don't think as an end user of the API we can figure out that the animation is still active. |
|
@ranjeshj can you weigh in on timeline @harvinders detecting when you are in this state would be challenging, but if you could you can fix the state by setting is open to false programmatically. With this change that is no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to set a teaching tip's IsOpen property to true while the closing animation is playing. This could cause the teaching tip to get in a state where IsOpen is true but it isn't displayed on screen. To work around this you would need to programmatically close and then reopen the tip. To fix this we can ignore IsOpen property changes while there are active animations.