Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NavViewContentMinimalMargin + adjust PaneContent cornerRadius #5595

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

karkarl
Copy link
Contributor

@karkarl karkarl commented Jul 30, 2021

Description

  • Add NavigationViewMinimalContentMargin to prevent gapping when overwriting NavigationViewContentMargin (ie. for L-Pattern)
  • Update PaneContent CornerRadius to top & bottom right only

Motivation and Context

Closes #5015

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jul 30, 2021
@karkarl
Copy link
Contributor Author

karkarl commented Jul 30, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley added area-NavigationView NavView control team-Controls Issue for the Controls team labels Aug 3, 2021
@karkarl
Copy link
Contributor Author

karkarl commented Aug 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl
Copy link
Contributor Author

karkarl commented Aug 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl
Copy link
Contributor Author

karkarl commented Aug 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl
Copy link
Contributor Author

karkarl commented Aug 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Aug 3, 2021
@karkarl karkarl merged commit b2563db into main Aug 4, 2021
@karkarl karkarl deleted the user/karenlai/NavViewFixes branch August 4, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinUI 2.6 - please don't round navigation view pane
3 participants