NavView Minimal Pane Sometimes Transparent OnLoad / OnWindowResize #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
added
area-NavigationView
beervoley
reviewed
Jul 22, 2021
beervoley
approved these changes
Jul 22, 2021
StephenLPeters
removed
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
force-pushed
the
user/karenlai/NavViewTransparentPaneFix
branch
from
72df4c3 to
8f0b8af
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
the
needs-cherrypicktorelease
kmahone
pushed a commit
that referenced
this pull request
Aug 10, 2021
…5531) * force close pane for minimal * changes from comments * add minWidth to compactModeThresholdWidth * update verification files * update verification files
|
🎉 Handy links: |
This was referenced Aug 19, 2021
Merged
StephenLPeters
removed
the
needs-cherrypicktorelease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NavigationView sometimes appear as transparent when in
NavigationViewDisplayMode::MinimalOnLoad and OnWindowResize. Turns out this is due to SplitView and NavigationView becoming out of sync, causing SplitView VisualState to evaluate toOpenOverlayLeftwhile NavigationView pane is closed while minimal.Motivation and Context
Fixes #5342