Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AutoSuggestBox SuggestionChosen Event to QuerySubmitted for NavView #5488

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

karkarl
Copy link
Contributor

@karkarl karkarl commented Jul 15, 2021

Description

NavigationView was previously using AutoSuggestBox's AutoSuggestBoxSuggestionChosenEventArgs event to close the NavView pane if it is in compact mode. AutoSuggestBoxSuggestionChosenEventArgs is fired each time an item is focused using keyboard navigation by design, causing NavView pane to close when trying to navigate the suggestion list using keyboard.

It has now been updated close pane using AutoSuggestBoxQuerySubmittedEventArgs instead.

Motivation and Context

Fixes #4622

How Has This Been Tested?

Manual testing

@karkarl
Copy link
Contributor Author

karkarl commented Jul 15, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@karkarl karkarl merged commit 996c2e5 into main Jul 19, 2021
@karkarl karkarl deleted the user/karenlai/NavViewAutoSuggestBoxFix branch July 19, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants