InkToolBar: add missing visual states to CustomToggleButton #5447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beervoley
requested review from
StephenLPeters,
karkarl,
ranjeshj and
tashatitova
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marksfoster
approved these changes
Jul 13, 2021
tashatitova
approved these changes
Jul 13, 2021
StephenLPeters
removed
the
needs-triage
ranjeshj
added
the
needs-cherrypicktorelease
kmahone
pushed a commit
that referenced
this pull request
Aug 10, 2021
Co-authored-by: Seva Iliushin <[email protected]>
|
🎉 Handy links: |
|
🎉 Handy links: |
This was referenced Aug 20, 2021
Merged
ranjeshj
removed
the
needs-cherrypicktorelease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing visual states to CustomToggleButton to fix #5296 (problem that's stated in that issue is related to the old styles) that will appear when using latest styles.
Motivation and Context
InkToolbarCustomToggleButtonstyle was missingCheckedvisual states - this PR fixes this issue.How Has This Been Tested?
Manually.