Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalendarView high contrast fixes - header area button styles + item background/stroke rest state #5310

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

kimsealls
Copy link
Contributor

Description

  • Consulted with the high contrast designer on the calendar view header and chevron buttons - these should all follow default ghost button styling in high contrast (the same style as command bar button - visible backplate on hover and press)
  • Created a resource for navigation header button rest state text to support default ghost button styling
  • While reviewing with the designer, we noticed a background and border showing in high contrast for all items at rest. Matched these styles to default styling and made them transparent

Motivation and Context

Buttons are now in alignment with the overall high contrast color system.

How Has This Been Tested?

Validated changes with the high contrast designer; controls test app

Screenshots (if appropriate):

https://microsoft.sharepoint-df.com/:f:/r/teams/windows/Confidential/Shared%20Documents/Pull%20Request%20Assets/CalendarHighContrast?csf=1&web=1&e=TTFBks

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 29, 2021
@ranjeshj
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj requested review from karkarl and teaP June 29, 2021 11:16
@ranjeshj ranjeshj added the team-Controls Issue for the Controls team label Jun 29, 2021
@ranjeshj ranjeshj requested a review from RBrid June 29, 2021 11:17
@ranjeshj ranjeshj added area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView and removed needs-triage Issue needs to be triaged by the area owners labels Jun 29, 2021
@teaP teaP merged commit 9e074ec into microsoft:main Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants