Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CommandBarFlyout not having shadows #5234

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Fix CommandBarFlyout not having shadows #5234

merged 3 commits into from
Jun 22, 2021

Conversation

StephenLPeters
Copy link
Contributor

Drop shadows require Z-translations to be set in order to draw, which was missing from CommandBarFlyout.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 21, 2021
@StephenLPeters
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj added area-Commanding AppBar, UICommand, MVVM, etc team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 21, 2021
@StephenLPeters
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters merged commit 3844707 into main Jun 22, 2021
@StephenLPeters StephenLPeters deleted the user/stpete/CommandBarFlyoutShadow branch June 22, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranjeshj ranjeshj ranjeshj approved these changes

Assignees
No one assigned
Labels
area-Commanding AppBar, UICommand, MVVM, etc team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenLPeters @ranjeshj