Add automation name to RadioButtons #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
marcelwgn
reviewed
May 26, 2021
dev/RadioButtons/RadioButtons.cpp
Outdated
Comment on lines
68
to
74
| const auto name = winrt::AutomationProperties::GetName(*this); | ||
| if (name.empty()) | ||
| { | ||
| // If the automation name isn't set, use header text as the name. | ||
| winrt::AutomationProperties::SetName(*this, SharedHelpers::TryGetStringRepresentationFromObject(Header())); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we should also do this on property changed for our header so it's staying up to date. Also could/should do it when the AutiomationProperties.Name property changes.
There was a problem hiding this comment.
I realized it wasn't really the right way to do it -- the header text should be returned from the automation peer. So this is all fixed up now. :)
ranjeshj
added
area-RadioButtons
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marcelwgn
reviewed
May 26, 2021
Sure, I added a part in the existing UIA test to verify that a group item exists with the header name. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
approved these changes
Jun 8, 2021
|
Will this be in a 2.x release or only 3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3183. RadioButtons had an AccessibilityView of Raw, so it didn't show up in the tree and its items were not grouped together. This is unlike other list-like controls, which appear like this:
list "Header Text"
text "Header Text"
list item "item 1"
list item "item 2"
etc.
So, RadioButtons now appears in the accessible tree as a group item when items inside it. If the control isn't given an accessible name, the header text is used, so it will appear like this:
group "Header Text"
text "Header Text"
radio button "item 1"
radio button "item 2"
etc.