-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MenuFlyoutItem size fix for mouse and touch. #4720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
changed the title
User/vsiliush/menuflyout fix
MenuFlyoutItem size fix with mouse and touch.
Apr 2, 2021
tashatitova
approved these changes
Apr 2, 2021
beervoley
changed the title
MenuFlyoutItem size fix with mouse and touch.
MenuFlyoutItem size fix for mouse and touch.
Apr 2, 2021
@beervoley can you create a separate PR with a test for this so we don't regress this in the future ? |
StephenLPeters
approved these changes
Apr 2, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 4, 2023
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The size of the MenuFlyoutItem was not correct when invoked with mouse/touch.
Motivation and Context
This PR adjusts padding of MenuFlyoutItem to make the size of each item 32px and 40px when using mouse/touch respectively.
How Has This Been Tested?
Manually.
Screenshots (if appropriate):
Opened with mouse click:
Opened with touch: