Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuFlyoutItem size fix for mouse and touch. #4720

Merged
merged 7 commits into from
Apr 3, 2021

Conversation

beervoley
Copy link
Contributor

@beervoley beervoley commented Apr 1, 2021

Description

The size of the MenuFlyoutItem was not correct when invoked with mouse/touch.

Motivation and Context

This PR adjusts padding of MenuFlyoutItem to make the size of each item 32px and 40px when using mouse/touch respectively.

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

Opened with mouse click:
mouse
Opened with touch:
touch

@beervoley beervoley added area-Menus team-Controls Issue for the Controls team labels Apr 1, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 1, 2021
@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley changed the title User/vsiliush/menuflyout fix MenuFlyoutItem size fix with mouse and touch. Apr 2, 2021
@beervoley beervoley changed the title MenuFlyoutItem size fix with mouse and touch. MenuFlyoutItem size fix for mouse and touch. Apr 2, 2021
@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Apr 2, 2021
@ranjeshj
Copy link
Contributor

ranjeshj commented Apr 2, 2021

@beervoley can you create a separate PR with a test for this so we don't regress this in the future ?

@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley merged commit c80132a into master Apr 3, 2021
@beervoley beervoley deleted the user/vsiliush/menuflyout-fix branch April 3, 2021 04:55
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 4, 2023
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Menus team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants