ToggleSwitch HC Colour Fix #4043
Conversation
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
area-ToggleSwitch
team-Controls
| <StaticResource x:Key="ToggleSwitchStrokeOffPointerOver" ResourceKey="SystemControlHighlightBaseMediumHighBrush" /> | ||
| <StaticResource x:Key="ToggleSwitchStrokeOffPressed" ResourceKey="SystemControlForegroundBaseHighBrush" /> | ||
| <StaticResource x:Key="ToggleSwitchStrokeOffDisabled" ResourceKey="SystemControlDisabledBaseMediumLowBrush" /> | ||
| <StaticResource x:Key="ToggleSwitchStrokeOffPointerOver" ResourceKey="SystemColorHighlightColor" /> |
There was a problem hiding this comment.
Does it work this way? I thought ResourceKey works for brushes? That it'd need to be SolidColorBrush pointing to ThemeResource SystemColorHighlightColor
There was a problem hiding this comment.
I had to point it to a colour instead, since ColorAnimations' TargetProperty only takes colour. When the resource was a brush, it was causing the elements to completely disappear. The only other option would be to remove ColorAnimations completely :(
There was a problem hiding this comment.
Yes I understand why you're doing this, I just don't think I've seen a system high contrast color referenced through ResourceKey like this. Creating a SolidColorBrush would definitely work though.
There was a problem hiding this comment.
This similar to the workaround we did for other controls, where instead of referencing the brush, we reference the colour that brush was pointing to originally. The updated colour here is what the HC brushes are pointing to. The referenced colours can be looked up on the internal tool.
|
please merge in master |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Motivation and Context
Fixes internal issue 31455320
How Has This Been Tested?
Visual verification
Screenshots (if appropriate):