-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding More Slider Examples to TestUI Page #4040
Adding More Slider Examples to TestUI Page #4040
Conversation
Added Examples of Sliders with TickPlacements as well as Vertical Slider examples
Added Examples of Sliders with TickPlacements as well as Vertical Slider examples
…tauk/microsoft-ui-xaml into user/mdtauk/AddSliderExamples
@karenbtlai @chingucoding Sorry for having to make a new Pull Request. I am still very new to submitting to and using github, and I deleted a local branch and it messed up the PR |
Removed whitespace I added to attempt to push a change to the file.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@mdtauk can you please merge in master. There was a test break that was fixed just now. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for adding a lot more samples to this page!
Additional sliders for test UI
I am Adding extra Slider control examples to the TestUI/SliderPage.xaml to include examples of TickPlacement properties - as well as adding vertically orientated examples.
Grid
with columns to separate the Horizontal and Vertical examplesStackPanel
in aScrollViewer
as the vertical examples would extend beyond the visible region with the lab conditions bounding toggled.Margin
values to the controls and panels to make it easier to identify each example.Motivation and Context
Following a suggestion I made in Pull Request #3768 by @karenbtlai I was asked to make a Pull Request adding more Slider examples to the TestUI SliderPage
How Has This Been Tested?
I built the solution and ran the MUXTestApp, checking the Page displayed correctly.
Screenshots (if appropriate):
This is a replacement for Pull Request #3821 as I messed up the branching by mistake