Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding More Slider Examples to TestUI Page #4040

Merged
merged 6 commits into from
Jan 29, 2021

Conversation

mdtauk
Copy link
Contributor

@mdtauk mdtauk commented Jan 27, 2021

Additional sliders for test UI

I am Adding extra Slider control examples to the TestUI/SliderPage.xaml to include examples of TickPlacement properties - as well as adding vertically orientated examples.

  • I used a Grid with columns to separate the Horizontal and Vertical examples
  • I wrapped each StackPanel in a ScrollViewer as the vertical examples would extend beyond the visible region with the lab conditions bounding toggled.
  • I added Margin values to the controls and panels to make it easier to identify each example.

Motivation and Context

Following a suggestion I made in Pull Request #3768 by @karenbtlai I was asked to make a Pull Request adding more Slider examples to the TestUI SliderPage

How Has This Been Tested?

I built the solution and ran the MUXTestApp, checking the Page displayed correctly.

Screenshots (if appropriate):

Light Theme Slider Page

Dark Theme toggled Slider Page

This is a replacement for Pull Request #3821 as I messed up the branching by mistake

Added Examples of Sliders with TickPlacements as well as Vertical Slider examples
Added Examples of Sliders with TickPlacements as well as Vertical Slider examples
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 27, 2021
@mdtauk mdtauk mentioned this pull request Jan 27, 2021
@mdtauk
Copy link
Contributor Author

mdtauk commented Jan 27, 2021

@karenbtlai @chingucoding Sorry for having to make a new Pull Request. I am still very new to submitting to and using github, and I deleted a local branch and it messed up the PR

Removed whitespace I added to attempt to push a change to the file.
@karkarl
Copy link
Contributor

karkarl commented Jan 27, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj added area-Slider team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jan 27, 2021
@ranjeshj
Copy link
Contributor

@mdtauk can you please merge in master. There was a test break that was fixed just now.

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for adding a lot more samples to this page!

@StephenLPeters StephenLPeters merged commit bdbe474 into microsoft:master Jan 29, 2021
@mdtauk mdtauk deleted the user/mdtauk/AddSliderExamples branch January 29, 2021 19:43
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 11, 2022
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Slider team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants