Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandBar updates #3993

Merged
merged 9 commits into from
Jan 27, 2021
Merged

CommandBar updates #3993

merged 9 commits into from
Jan 27, 2021

Conversation

teaP
Copy link
Contributor

@teaP teaP commented Jan 21, 2021

Visual changes to CommandBar, AppBarButton, and AppBarToggleButton. I removed the CommandBarWithoutRevealStyle since, I figure, the new style IS without reveal.

image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 21, 2021
@marcelwgn
Copy link
Collaborator

Could this cause merge issues with #3852?

@teaP
Copy link
Contributor Author

teaP commented Jan 21, 2021

Could this cause merge issues with #3852?

Good question. I think probably not... but let's make a couple quick changes on your PR and get it into master, then I can merge it in and check!

@StephenLPeters StephenLPeters added area-Commanding AppBar, UICommand, MVVM, etc area-Styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jan 22, 2021
@harvinders
Copy link

It was one area where reveal really shined. I hope there would be a way to enable it if we want in the commandbar.

@mdtauk
Copy link
Contributor

mdtauk commented Jan 23, 2021

It was one area where reveal really shined. I hope there would be a way to enable it if we want in the commandbar.

Reveal its being depricated with this visual refresh

@ranjeshj
Copy link
Contributor

Could this cause merge issues with #3852?

Good question. I think probably not... but let's make a couple quick changes on your PR and get it into master, then I can merge it in and check!

That PR is merged now, @teaP you can merge in master to get those changes.

@teaP
Copy link
Contributor Author

teaP commented Jan 25, 2021

Separators look good to me (except the color, but that will be updated).
image

@teaP
Copy link
Contributor Author

teaP commented Jan 25, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova
Copy link
Contributor

Separators look good to me (except the color, but that will be updated).
image

What's that overlay on the light image? Gray background partly covering everything from the bottom?

@tashatitova
Copy link
Contributor

Capture

@teaP
Copy link
Contributor Author

teaP commented Jan 25, 2021

What's that overlay on the light image? Gray background partly covering everything from the bottom?

That is just the background grid of the test app showing through slightly.

@mdtauk
Copy link
Contributor

mdtauk commented Jan 25, 2021

With rounded corners, will the command bar still be flush with the edges of the screen/panel?

I asked this with the new rounded scrollbar because it feels as if it should have some padding, maybe 4px so its close without touching.

@tashatitova
Copy link
Contributor

What's that overlay on the light image? Gray background partly covering everything from the bottom?

That is just the background grid of the test app showing through slightly.

Oh, so it's that transparent. Didn't know that.

@teaP
Temporarily disable failing visual tree test. Fix AppBarButton sizing…
9c79776 
… test (since I'm overriding the height in WinUI, it will be the same on all RS. Also update background sizing on toggle buttons.
@teaP
Copy link
Contributor Author

teaP commented Jan 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley mentioned this pull request Jan 26, 2021
Merged
5 tasks
@ranjeshj ranjeshj merged commit 31733c8 into master Jan 27, 2021
@ranjeshj ranjeshj deleted the user/teaP/CommandBarOffMaster branch January 27, 2021 20:39
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 8, 2022
@Kinnara
Port microsoft/microsoft-ui-xaml#3993
f72221d
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 8, 2022
@Kinnara
Port microsoft/microsoft-ui-xaml#3993 (#528)
94269c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tashatitova tashatitova tashatitova left review comments

@karkarl karkarl karkarl approved these changes

@YuliKl YuliKl Awaiting requested review from YuliKl

@marksfoster marksfoster Awaiting requested review from marksfoster

Assignees
No one assigned
Labels
area-Commanding AppBar, UICommand, MVVM, etc area-Styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@teaP @marcelwgn @harvinders @mdtauk @ranjeshj @tashatitova @karkarl @StephenLPeters