ItemsRepeater: Fix bug where inserting at front would result in unrendered items #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ranjeshj
added
area-ItemsRepeater
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Which WinUI version should we expect this to go into? |
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 20, 2020
3 tasks
This was referenced Jan 6, 2021
Closed
This was referenced Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When inserting at index 0, the comparison whether we are in the realization range or not fails since
0>0 == false. I've updated the check to also allow inserting at the start of the realization rect and make it possible to have that item rendered if there is enough space.Motivation and Context
Fixes #3381
How Has This Been Tested?
Added interaction test, unfortunately, this behavior did not repro in an API test (reliably).
Screenshots (if appropriate):