Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow microsoft-ui-xaml to support multiple sets of styles #3690

Merged
merged 18 commits into from
Dec 4, 2020
Merged

Allow microsoft-ui-xaml to support multiple sets of styles #3690

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
54196a0
update customtask
licanhua Nov 24, 2020
b51fd0a
update project to use the customtool and support UseVisualStyle
licanhua Nov 24, 2020
4ccff39
support new flag in api
licanhua Nov 25, 2020
8ea38de
missing one file change for custombuild task
licanhua Nov 30, 2020
5e20518
update to new api and address some comments
licanhua Dec 1, 2020
2255031
fix the ->
licanhua Dec 1, 2020
d793e7d
script to move master xaml to v2.5 and add them to proj
licanhua Dec 2, 2020
3f6ced9
manually correct the missing items
licanhua Dec 2, 2020
df4a9a5
vcxproj back to UTF8
licanhua Dec 2, 2020
48bbfd1
standard the name and replace previous with 2dot5
licanhua Dec 2, 2020
63c27b9
batch remove last line for project
licanhua Dec 3, 2020
5f9a788
remove pips and address commentss
licanhua Dec 3, 2020
2117bcc
trim last line
licanhua Dec 3, 2020
89f1f43
remove newline at the end of file
licanhua Dec 3, 2020
27c477d
fix ##[error]dev\dll\XamlControlsResources.cpp(249,0): Error C26449: …
licanhua Dec 3, 2020
7207f8f
remove return type in lambda
licanhua Dec 3, 2020
47e00c3
remove Expander_v2.5.xaml, move merge.bat to tools and fix the test f…
licanhua Dec 3, 2020
ca3d709
fix test
licanhua Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/dll/XamlControlsResources.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ void SetDefaultStyleKeyWorker(winrt::IControlProtected const& controlProtected,
if (auto control5 = controlProtected.try_as<winrt::IControl5>())
{
winrt::Uri uri{
[]() -> wstring_view {
[]() -> std::wstring {

// RS3 styles should be used on builds where ListViewItemPresenter's VSM integration works.
const bool isRS3OrHigher = SharedHelpers::DoesListViewItemPresenterVSMWork();
Expand Down