NavigationView incorrectly sizing items as compact on launch

[ojhad]

Description

NavigationView was launching into expanded mode while the items were being sized as compact.
This is happening due to the pane being closed and opened during the set up. This should not be happening while internal logic is setting up the correct state. Used an existing flag to ensure this.

Motivation and Context

Fixes #2635

How Has This Been Tested?

Manual testing

[marcelwgn]

Should we add a test for this?

[StephenLPeters]

Should we add a test for this?

I don't think we have a consistent repro which would make effectively testing it hard. @ojhad

[StephenLPeters]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ojhad]

Should we add a test for this?

Not having a consistent repro bundled with the fact that this scenario is only hit in a specific configuration upon app launch makes the test setup for this require a lot more work than normal, which is why I left out writing a test for this for now.

[marcelwgn]

Not having a consistent repro bundled with the fact that this scenario is only hit in a specific configuration upon app launch makes the test setup for this require a lot more work than normal, which is why I left out writing a test for this for now.

Fair enough, if the test would require a lot of work or wouldn't be reliable anyway, I guess in this case a test won't be necessary or helpful.

[StephenLPeters]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[StephenLPeters]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ranjeshj]

Is this an issue with selection model raising events when it should not be ? If so, lets file a bug for it.

[msft-github-bot]

🎉Microsoft.UI.Xaml v2.5.0-prerelease.200812001 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official Nuget Release