-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ToggleSplitButton's IsCheckedProperty not being a public DP #2258
Fix ToggleSplitButton's IsCheckedProperty not being a public DP #2258
Conversation
Technically, I think this would need API review... @MikeHillberg thoughts? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@Felix-Dev thanks for fixing this. Can you add a quick api test in https://github.com/microsoft/microsoft-ui-xaml/blob/master/dev/SplitButton/APITests/SplitButtonTests.cs ? You can just create the button, set the property, get it and check its value. You could also use SetValue/GetValue to validate. |
@ranjeshj Added an API test. Should I remove the button I added to the MUXControlsTestApp (see image in opening post)? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Following up on this. This should be a quick review, so no worries about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR adds a public DP IsCheckedProperty to the ToggleSplitButton.
Motivation and Context
Fixes #2218.
How Has This Been Tested?
Tested locally.
Open Questions
[WUXC_VERSION_PREVIEW]
)?(1)
