Fix NavigationView pane not closing in minimal/compact mode when selecting an item #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tically selecting items * Add test to prevent this regression in the future
msft-github-bot
added
the
needs-triage
ranjeshj
added
area-NavigationView
marcelwgn
reviewed
Apr 7, 2020
Co-Authored-By: Marcel Wagner <[email protected]>
ojhad
reviewed
Apr 7, 2020
ojhad
approved these changes
Apr 7, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced with commit 5d444b6 which prevented the NavigationView pane to be closed in minimal/compact mode after selecting the Settings item or selecting an item programmatically (using NavigationView.SelectedItem).
Also added an interaction test to prevent this regression from occuring in the future.
Motivation and Context
Fixes #2244.
How Has This Been Tested?
Tested visually and added interaction test.