Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split RadioButtons tests into smaller chunks and workloads #2214

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Split RadioButtons tests into smaller chunks and workloads #2214

merged 4 commits into from
Apr 6, 2020

Conversation

marcelwgn
Copy link
Collaborator

Description

I've split up the larger tests into smaller chunks and added them into TestSuite's in order to reduce the time we need to rerun tests and potentially improve test reliability

image

Motivation and Context

Potentially Fixes #2160

How Has This Been Tested?

Ran tests

Screenshots (if appropriate):

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Apr 2, 2020
@ranjeshj ranjeshj added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency and removed needs-triage Issue needs to be triaged by the area owners labels Apr 2, 2020
@StephenLPeters StephenLPeters added needs-triage Issue needs to be triaged by the area owners team-Controls Issue for the Controls team area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency and removed area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency needs-triage Issue needs to be triaged by the area owners labels Apr 2, 2020
@ranjeshj ranjeshj requested a review from StephenLPeters April 3, 2020 14:01
@ranjeshj
Copy link
Contributor

ranjeshj commented Apr 3, 2020

@chingucoding can you please merge with master, the stability fixes are in now.

@marcelwgn
Copy link
Collaborator Author

@ranjeshj Good idea, done

@ranjeshj
Copy link
Contributor

ranjeshj commented Apr 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

I don't think splitting the individual tests is the right approach. I think bucketing the tests into different suites is sufficient...

@marcelwgn
Copy link
Collaborator Author

@StephenLPeters I've reverted my commit and just added test suite properties to the tests.

StephenLPeters
StephenLPeters approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj merged commit 22ff769 into microsoft:master Apr 6, 2020
@kmahone kmahone mentioned this pull request Apr 6, 2020
Merged
@marcelwgn marcelwgn deleted the test-reliability branch May 15, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RadioButtons tests take too long
4 participants
@marcelwgn @ranjeshj @StephenLPeters @msft-github-bot