Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HNav based on API Review #2196

Merged
merged 6 commits into from
Apr 4, 2020
Merged

Update HNav based on API Review #2196

merged 6 commits into from
Apr 4, 2020

Conversation

ojhad
Copy link
Contributor

@ojhad ojhad commented Mar 31, 2020

Fixes #2195

Description

After going through an API review for the new Hierarchical NavigationView, there were two recommendations:

  1. Rename NavigationViewCollapsedEventArgs and NavigationViewExpandingEventArgs to NavigationViewItemCollapsedEventArgs and NavigationViewItemExpandingEventArgs

  2. Add an ExpandingItem and CollapsedItem property to the args

How Has This Been Tested?

Updated test to verify new changes

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Mar 31, 2020
@ranjeshj ranjeshj requested a review from MikeHillberg March 31, 2020 12:30
@StephenLPeters StephenLPeters added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 31, 2020
@kmahone
Copy link
Member

kmahone commented Apr 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Apr 3, 2020

@ojhad looks like there were some test failures in the test pass:

InteractionTests.NavigationViewTests.VerifyExpandCollpaseFunctionality
InteractionTests.NavigationViewTests.SelectingNonTopLevelItemInOverflow

@ojhad
Copy link
Contributor Author

ojhad commented Apr 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ojhad
Copy link
Contributor Author

ojhad commented Apr 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ojhad ojhad merged commit 5ebf958 into master Apr 4, 2020
@ojhad ojhad deleted the user/ojhad/hnavapireviewupdated branch April 4, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters left review comments

@ranjeshj ranjeshj ranjeshj approved these changes

@MikeHillberg MikeHillberg Awaiting requested review from MikeHillberg

Assignees
No one assigned
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Hierarchical NavigationView based on API Review
5 participants
@ojhad @kmahone @StephenLPeters @ranjeshj @msft-github-bot