Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not update extension binaries execution permissions #107

Closed
theAndrewCline opened this issue Feb 21, 2018 · 31 comments
Closed

Could not update extension binaries execution permissions #107

theAndrewCline opened this issue Feb 21, 2018 · 31 comments

Comments

@theAndrewCline
Copy link

Product and Version [VSCode]:
OS Version [macOS]:
Live Share Extension Version:
Target Platform or Language [Node.js]:

Steps to Reproduce / Scenario:

  1. Installed and could not start

error.zip

@avanderhoorn
Copy link
Member

Another sample log.
logs.zip

@abl
Copy link

abl commented Mar 1, 2018

macOS 10.13.3, clean install of VS Code 1.20.1, no other extensions. VS Live Share 0.2.163.

The error I get is "Could not update the extension binaries execution permissions." This leads me to out/src/util.js:299 and it appears the paths it's having trouble with (from package.json) are:

./dotnet_modules/vsls-agent
./dotnet_modules/Microsoft.Cascade.VSCodeAdapter
./dotnet_modules/Microsoft.Cascade.VSCodeHostAdapter

None of which exist relative to ~/.vscode/extensions/ms-vsliveshare.vsliveshare-0.2.163.

@abl
Copy link

abl commented Mar 1, 2018

The following paths do exist:

./dotnet_modules/vsls-agent.dll
./dotnet_modules/Microsoft.Cascade.VSCodeAdapter.dll
./dotnet_modules/Microsoft.Cascade.VSCodeHostAdapter.dll

@abl
Copy link

abl commented Mar 1, 2018

Disable, uninstall, reload, install, reload lead to Live Share downloading the extra bits it needed; appears to be working now. Logs attached.

working_install.zip

@srivatsn
Copy link

srivatsn commented Mar 2, 2018

Thanks @abl for mentioning that the files don't actually exist on disk. It looks like we have a path where the code that's copying the files is failing silently in some cases (it's expected to fail the install if the copy fails). We'll investigate.

@theAndrewCline
Copy link
Author

I was able to get around it by uninstalling VS Code, reinstall of code and Live Share. Working fine now.

@Chuxel
Copy link
Member

Chuxel commented Apr 3, 2018

@theAndrewCline @abl Have you seen this one happen again? We just released a fix for #112 that might help with this particular scenario as well. I'm curious if anyone has seen it happen recently.

@aaroncraig10e
Copy link

I'm seeing this now as of a few hours ago. The error pops up anytime I reload the window.

Let me know what info I can give you to help debug.

@Chuxel
Copy link
Member

Chuxel commented Apr 3, 2018

@aaroncraig10e So sorry to hear that! Thanks for letting us know. We recently released an updated version of the extension. Am I correct in assuming you'd used a previous version of the extension without issue or was this your first install?

@aaroncraig10e
Copy link

aaroncraig10e commented Apr 3, 2018

I've used it before once or twice -- have yet to have a session work with it, but I haven't seen any errors yet. Mostly it just doesn't sync, or the session silently dies shortly after beginning.

Very hopeful for a working version soon -- the idea is great so keep up the good work! 👍

@Chuxel
Copy link
Member

Chuxel commented Apr 3, 2018

@aaroncraig10e It would be great to get your logs if you could mail them to [email protected] or attach them here. You can get them by running the "Live Share: Export Logs" command. After that I'd be interested to know if uninstalling and reinstalling resolves the problem for you. We've seen that work in the past and believe this is somehow tied to corrupted downloads but we clearly haven't found all the spots given what you are encountering. Appreciate the help and feedback!

@aaroncraig10e
Copy link

Attaching the logs -- I will re-install before trying to share a session here and report back here if that changes things.
live-share-logs.zip

@theAndrewCline
Copy link
Author

@Chuxel I have not had any issues since I uninstalled VS Code and Reinstalled. I’ll double check soon.

@aaroncraig10e
Copy link

aaroncraig10e commented Apr 3, 2018

So this is weird -- when I go to reinstall the plug in, I discover that there are two!

The one that appears as installed on my system is "ms-vsliveshare.vsliveshare". Another appears when I search for available plugins called "MS-vsliveshare.vsliveshare".

Attached are screenshots of the two -- note that one has download counts and a repository link, while the other does not.

Could this be part (or all) of the problem?

I installed the one I have (IIRC) by following the prompts in the email I received when I was invited to the preview beta.

screen shot 2018-04-03 at 1 23 29 pm

screen shot 2018-04-03 at 1 23 07 pm

@Chuxel
Copy link
Member

Chuxel commented Apr 3, 2018

@aaroncraig10e That is super strange! Out of curiosity, are you on a Mac with a case sensitive filesystem enabled?

You can run diskutil info / | grep Name and see if the name mentions being case sensitive to check.

@aaroncraig10e
Copy link

@Chuxel no, not case sensitive, judging by this output:

$ diskutil info / | grep Name
   Volume Name:              Macintosh HD
   Name (User Visible):      APFS

@Chuxel
Copy link
Member

Chuxel commented Apr 3, 2018

@aaroncraig10e That's really odd - To flush things out, try uninstalling both, bouncing VS Code, and the installing from the marketplace. I'm not 100% sure how you could have gotten in that state so it will be interesting to see if it fixes the issue. Hopefully this unblocks you while we see what we can figure out.

@grork
Copy link

grork commented Apr 3, 2018

Before doing that, can you share which version is reported for each one? (Not seeing it in the screen shot)

@srivatsn
Copy link

srivatsn commented Apr 3, 2018

This could be a manifestation of microsoft/vscode#43813 (comment) - VS Code extracts an extension to a .<extension>.<version> folder and moves it later and in some cases it looks like the old one gets left behind. Maybe that appears as two extensions in the extensions tab

@aaroncraig10e
Copy link

To be clear, only one is reported as installed (and it's the one without a repository link, stars or a download count).

It's version is 0.2.307
screen shot 2018-04-03 at 3 04 23 pm

The other one is not reported as installed, and has a repository link, stars and download count.

It's version is also 0.2.307
screen shot 2018-04-03 at 3 05 18 pm

I'll uninstall the one now, and reinstall the other that looks more legit, and see if that clears things up.

@aaroncraig10e
Copy link

Uninstalled and reinstalled, and no change. Is it possible that (because the version numbers are the same) it's reinstalled the same plugin from some cache as mentioned by @srivatsn?

Where can I find these cached files so I can nuke them?

@Chuxel
Copy link
Member

Chuxel commented Apr 4, 2018

@aaroncraig10e Extensions are stored in ~/.vscode/extensions (or ~/.vscode-insiders/extensions/ for insiders). You should be able to simply delete the folder with the extension in this location to remove it. ms-vsliveshare.vsliveshare-0.2.307 would be the folder name for the Live Share version for 0.2.307. Note that renaming the folder isn't enough.

I'd actually be interested to know if you see two extensions at that location.

@Chuxel
Copy link
Member

Chuxel commented Apr 4, 2018

@aaroncraig10e Oh - one thing I forgot to mention, if the bug Sri pointed out is indeed the issue, there would be another extension at .ms-vsliveshare.vsliveshare-0.2.307 (note the dot before the extension name).

To see this in Finder use Command+Shift+. (period) to turn on seeing hidden files. Otherwise use ls -a in the terminal.

After that you'd see both:
.ms-vsliveshare.vsliveshare-0.2.307
ms-vsliveshare.vsliveshare-0.2.307

@aaroncraig10e
Copy link

That seems to have fixed it -- I did not have the hidden directory version of the plugin.

I kept the original folder if you're interested in seeing it.

@Chuxel
Copy link
Member

Chuxel commented Apr 4, 2018

@aaroncraig10e Yes, that would be awesome so we can see what might have gone wrong.

@aaroncraig10e
Copy link

Here you go: https://drive.google.com/file/d/15bWObn4gfsvEupjSOzx9AbW7ftdKaf12/view?usp=sharing

Hope I got the share settings right 😄

@Chuxel
Copy link
Member

Chuxel commented Apr 4, 2018

@aaroncraig10e You did, came down without a hitch! We'll take a look. Thanks so much for helping and bearing with us and glad you were unblocked! Love to hear more feedback as you dig in as well.

@Chuxel
Copy link
Member

Chuxel commented Apr 4, 2018

For anyone that hits this, try the following:

  1. Uninstall the extension, shut down VS Code, and reinstall
  2. If that fails or you see two extensions installed:
    1. Go to ~/.vscode/extensions (or ~/.vscode-insiders/extensions/ for insiders)
    2. Delete both of these if present (where 0.X.XXX is the Live Share extension version):
      • .ms-vsliveshare.vsliveshare-0.X.XXX
      • ms-vsliveshare.vsliveshare-0.X.XXX

Let us know what variation you hit. Thanks!!

@aaroncraig10e
Copy link

@Chuxel Will definitely give you feedback as I can -- I do a lot of mentoring and heavily lean on pair sessions, so really hoping this plugin facilitates that!

@Chuxel
Copy link
Member

Chuxel commented Apr 18, 2018

We just released v0.2.399 that should provide some improvements in this space. It would be interesting to hear if anyone hits this again with this update.

@lostintangent
Copy link
Member

Closing this as resolved since we addressed it in an update, and we haven't seen it reported since. Please re-open if you experience this bug again. Thanks!

Chuxel pushed a commit that referenced this issue Sep 19, 2018
Add a couple clarifications for accessibility purposes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants