-
Notifications
You must be signed in to change notification settings - Fork 823
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
39 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,32 @@ | ||
{ | ||
"editor.rulers": [80] | ||
"editor.rulers": [ | ||
80 | ||
], | ||
"cSpell.words": [ | ||
"ABAP", | ||
"EBNF", | ||
"LSIF", | ||
"Naur", | ||
"RGBA", | ||
"Retriggers", | ||
"Struct", | ||
"Sublime's", | ||
"Unregistration", | ||
"bibtex", | ||
"downcase", | ||
"hover's", | ||
"lightbulbs", | ||
"quickfix", | ||
"refactorings", | ||
"retrigger", | ||
"sectionid", | ||
"textedit", | ||
"uhhhh", | ||
"uinteger", | ||
"unregister", | ||
"unregisterations", | ||
"unregistrations", | ||
"upcase", | ||
"workspaceedit" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2389208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
diagnostics's
correct English grammar?Diagnotics
is the plural form ofdiagnostic
. From Grammarly: No matter which style guide you use, add only the apostrophe to plural proper nouns that end in s: The Harrises’ house The Smiths’ vacation. The MLA Handbook notes that if it's irregular, one would still add "'s". But I don't thinkdiagnostic
is irregular. However, the main problem is that the data typeDiagnostic
in this spec encodes a single (i.e., singular, not plural) diagnostic message. If the type represented multiple diagnostic, then I would have expected the declarationmessage: string
to be instead a list or array of string. In other words, I think the original spelling--diagnostic's
--is the correct form.2389208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out. FIxed it.