-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most python tests windows #662
Conversation
(conv_2d_no_bias)
Set Python version
We could install GCC but probably want to move towards MSVC anyway
A subset of the Python tests now pass on Windows! It's notably not running the TorchScript2Knossos tests see #659 or the direct GCC/pybind tests. I had to do some ugly things with pinning to an earlier version of pip and using the legacy resolver as the new resolver interacts poorly with PyTorch version numbers. Note: I don't reproduce this breakage locally (on Windows, or Ubuntu) so it may be only on Python 3.7 (on Windows or the particular set-up of the devops machines). Also had to disable the cache directory per: We might want to separately make these Pip changes/pinning to the Linux build for consistency / safety. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fab, thanks!
No description provided.