Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most python tests windows #662

Merged
merged 9 commits into from
Mar 19, 2021
Merged

Most python tests windows #662

merged 9 commits into from
Mar 19, 2021

Conversation

cgravill
Copy link
Contributor

No description provided.

@cgravill
Copy link
Contributor Author

cgravill commented Mar 19, 2021

A subset of the Python tests now pass on Windows!

It's notably not running the TorchScript2Knossos tests see #659 or the direct GCC/pybind tests.

I had to do some ugly things with pinning to an earlier version of pip and using the legacy resolver as the new resolver interacts poorly with PyTorch version numbers.
https://pip.pypa.io/en/latest/user_guide/#changes-to-the-pip-dependency-resolver-in-20-3-2020

Note: I don't reproduce this breakage locally (on Windows, or Ubuntu) so it may be only on Python 3.7 (on Windows or the particular set-up of the devops machines). Also had to disable the cache directory per:
https://stackoverflow.com/a/31526029/35544

We might want to separately make these Pip changes/pinning to the Linux build for consistency / safety.

@cgravill cgravill marked this pull request as ready for review March 19, 2021 11:04
@cgravill cgravill changed the title Try python tests windows Most python tests windows Mar 19, 2021
Copy link
Contributor

@awf awf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab, thanks!

@cgravill cgravill merged commit 90f84bd into master Mar 19, 2021
@cgravill cgravill deleted the cogravil/python_tests_windows branch March 19, 2021 13:33
@cgravill cgravill mentioned this pull request Mar 26, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants