Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript - isomorphic setup, first set of middlewares #728

Merged
merged 46 commits into from
Mar 21, 2022

Conversation

nikithauc
Copy link
Contributor

@nikithauc nikithauc commented Oct 16, 2021

fixes #489
fixes #361

  • Isomorphic set up
  • Adding RetryHandler, RedirectHandler and FetchHandlers. Added MiddlewareContext and updated HttpClient with logic to set middleware and fetch implementation.
  • Removed webstream polyfill in abstractions and fetch libraries.
  • Introducing unit tests targeting node and browser
  • Introducing linting with ESLint.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at that!

@nikithauc nikithauc force-pushed the enhancement/nikithauc-client-middleware-setup branch from e04f860 to 0274947 Compare February 2, 2022 04:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nikithauc nikithauc marked this pull request as ready for review March 18, 2022 09:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nikithauc nikithauc merged commit 223c71f into main Mar 21, 2022
@nikithauc nikithauc deleted the enhancement/nikithauc-client-middleware-setup branch March 21, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeScript Pull requests that update Javascript code
Projects
Archived in project
3 participants