Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry PoC #6128

Merged
merged 43 commits into from
Feb 27, 2025
Merged

Telemetry PoC #6128

merged 43 commits into from
Feb 27, 2025
+1,595 −83

Conversation

calebkiage
Copy link
Contributor

No description provided.

baywet
baywet reviewed Feb 11, 2025
View reviewed changes
baywet
baywet reviewed Feb 12, 2025
View reviewed changes
@calebkiage
Update packages
1631e6c
@calebkiage
Merge branch 'main' into feat/telemetry
46c86c2 
# Conflicts:
#	src/kiota/kiota.csproj
@calebkiage
Use a counter for the number of generations
0514e18 
Use a counter for command executions
Remove generate client child span (should be covered when kiota builder is instrumented)
@calebkiage
Fetch telemetry configuration from config file
4550a38
@calebkiage
Format doc
0903e11
@calebkiage
Merge branch 'main' into feat/telemetry
5c1c25e
@calebkiage
Instrument remove client handler
e21208b
@calebkiage
Merge remote-tracking branch 'origin/feat/telemetry' into feat/telemetry
c2baaf7
@calebkiage
Add instrumentation to plugin add command
67f1208
@calebkiage
Fix plugin add handler activity name
ec02e57
@calebkiage
Add more instrumentation for plugin commands
e0f1275 
Rename some attributes
Fix remove client activity name
@calebkiage
Instrument legacy generate command
f5de4a8
@calebkiage
Format code
fb0b2e5
@calebkiage
Merge branch 'main' into feat/telemetry
40022f0
@calebkiage
Update appinsights connection string
dc879e0
@calebkiage
Add telemetry for download command
1dc1521
@calebkiage
Format code
d2a7c06
@calebkiage calebkiage marked this pull request as ready for review February 24, 2025 14:59
@calebkiage calebkiage requested a review from a team as a code owner February 24, 2025 14:59
baywet
baywet reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment from my end
There's also a bunch of commented out code and some todos. SonarCloud has already flagged those and we should clean this up during merge.

I'm also going to request a squash merge for this one.

baywet
baywet previously approved these changes Feb 24, 2025
View reviewed changes
baywet
baywet previously approved these changes Feb 25, 2025
View reviewed changes
@calebkiage calebkiage enabled auto-merge (squash) February 27, 2025 08:41
andrueastman
andrueastman reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments. Otherwise looks good from my side.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'kiota'

Failed conditions
21.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@calebkiage calebkiage merged commit 7976e7e into main Feb 27, 2025
282 of 283 checks passed
@calebkiage calebkiage deleted the feat/telemetry branch February 27, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebkiage @andrueastman @baywet