Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK version in global.json file #5535

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

captainsafia
Copy link
Member

The version number currently used doesn't match with an actual SDK version. It should be 8.0.xxx. I've updated it to use the latest SDK version.

The version number currently used doesn't match with an actual SDK version. It should be `8.0.xxx`. I've updated it to use the latest SDK version.
@captainsafia captainsafia requested a review from a team as a code owner October 6, 2024 17:05
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this @captainsafia

Just to confirm, are you running into any issues with the current configuration?
I believe the rollForward parameter should allow for use of higher versions of the SDK.

@captainsafia
Copy link
Member Author

@andrueastman Yes, the install-dotnet scripts that are popularly used to install dependencies will fail because the version format is incorrect (it should be 8.0.xxx). The rollForward doesn't do anything in this case since the underlying version format is malformed.

@andrueastman andrueastman enabled auto-merge October 7, 2024 16:45
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution here @captainsafia

@andrueastman andrueastman merged commit a1be7bc into microsoft:main Oct 7, 2024
205 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants