Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generation of enum array in query #4226

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

crobibero
Copy link
Contributor

Fixes #4225

@crobibero crobibero requested a review from a team as a code owner February 24, 2024 20:02
@oasissoman

This comment was marked as spam.

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this @crobibero

Any chance you can run dotnet format to fix the linting error in the CI?

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I suggested a couple of changes to avoid side effects.

src/Kiota.Builder/Extensions/OpenApiSchemaExtensions.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Extensions/OpenApiSchemaExtensions.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/KiotaBuilder.cs Outdated Show resolved Hide resolved
@crobibero
Copy link
Contributor Author

@baywet Thank you for the review- looks like I had some leftover changes that I had made when trying to track down the issue

baywet
baywet previously approved these changes Feb 26, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! even better than my suggestion!

@baywet baywet enabled auto-merge February 26, 2024 19:06
auto-merge was automatically disabled February 26, 2024 19:12

Pull Request is not mergeable

auto-merge was automatically disabled February 26, 2024 19:12

Pull Request is not mergeable

@andrueastman
Copy link
Member

@crobibero The intergration tests are failing for the PR when generating SDKs for the apisguru::github.com:api.github.com endpooint. Any chance you can take a look before we merge?

@crobibero
Copy link
Contributor Author

@andrueastman The breakage doesn't look to be from this PR as others are also failing, and I don't have the ability to run the the script that is failing on my machine; so no.

@andrueastman
Copy link
Member

@andrueastman The breakage doesn't look to be from this PR as others are also failing, and I don't have the ability to run the the script that is failing on my machine; so no.

Thanks for double checking. Lemme take a look before we merge.

@andrueastman
Copy link
Member

Confirmed that failures related to #4174 (comment)

Tracked by #4241

Will update suppressions in a separate PR.

andrueastman
andrueastman previously approved these changes Feb 27, 2024
@andrueastman andrueastman dismissed stale reviews from baywet and themself via 8bfb73d February 28, 2024 08:57
andrueastman
andrueastman previously approved these changes Feb 28, 2024
@andrueastman andrueastman merged commit d8c0577 into microsoft:main Feb 28, 2024
184 of 192 checks passed
@crobibero crobibero deleted the enum-array branch February 28, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

C# - Query Enum Array generated as string[]
4 participants