-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generation of enum array in query #4226
Conversation
b00a7ba
to
f1982db
Compare
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this @crobibero
Any chance you can run dotnet format
to fix the linting error in the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I suggested a couple of changes to avoid side effects.
@baywet Thank you for the review- looks like I had some leftover changes that I had made when trying to track down the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! even better than my suggestion!
Pull Request is not mergeable
Pull Request is not mergeable
@crobibero The intergration tests are failing for the PR when generating SDKs for the |
@andrueastman The breakage doesn't look to be from this PR as others are also failing, and I don't have the ability to run the the script that is failing on my machine; so no. |
Thanks for double checking. Lemme take a look before we merge. |
Confirmed that failures related to #4174 (comment) Tracked by #4241 Will update suppressions in a separate PR. |
Fixes #4225