Fixes intermittent issues in model renaming. #3187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes microsoftgraph/msgraph-sdk-dotnet#2084
After changes made in #3107 involved the
CodeType
sharing the name with theTypeDefinition
property to limit unnecessary string copies. This however led to indeterministic renaming of model types as renaming aTypeDefinition
instance through the parameter type or discriminator mapping would lead to indeterministic results depending on which was processed first and sometimes fail to check for conflicts after renaming.An example include renaming
microsoft.graph.directory
tomicrosoft.graph.directoryObject
(which already exists rather than resolving the renaming conflict) when theTypeDefinition
when encountered through the discriminator mapping of the base rather than as child element of themicrosoft.graph
namespace.This PR therefore eliminates other points of
TypeDefinition/CodeType
renaming(as multiple string copies are no longer held) by dropping functions that looked up theTypeDefinition/CodeType
name indirectly through the