Fix PHP request executor methods returning enums #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndiritu
force-pushed
the
fix/php-requestexecutor-enum
branch
from
b92a5d1 to
38f7d69
Compare
|
Fixing integration test failure |
Ndiritu
force-pushed
the
fix/php-requestexecutor-enum
branch
from
38f7d69 to
dd70b2d
Compare
Will be addressed in separate PR. Issues are not related to this change & seem to be occurring as a result of duplicate properties in composed type wrappers and some models, not just for PHP. |
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls
sendPrimitiveAsyncon the request adapter with the enum class name.depends on microsoft/kiota-http-guzzle-php#69
closes microsoftgraph/msgraph-beta-sdk-php#182