-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire GitHub pages #2486
Retire GitHub pages #2486
Conversation
jasonjoh
commented
Mar 29, 2023
- Deleted old docs
- Created custom 404 page pointing users to our new docs page (preview)
Co-authored-by: Vincent Biret <[email protected]>
Thanks for the reminder! I added these into this PR I'm currently working on: https://github.com/MicrosoftDocs/openapi-docs-pr/pull/15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also a bunch of links in the main readme need to be updated.
@baywet I just realized I did not copy over contributing.md to Learn. I'm not sure that content belongs in Learn. How do you feel about adding it back to the root of the repo? |
@jasonjoh it's usually a section of the readme. I'm not sure why we originally moved it to a separate page. But yes it should be on this repo and at the root. See an example |
Yeah, I created a CONTRIBUTING.md and copied the content from the old one. It was more about required and recommended tools, and how to handle the submodule setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. I just removed the submodule instructions as we removed the submodule itself, it was generating too much noise