Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire GitHub pages #2486

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Retire GitHub pages #2486

merged 7 commits into from
Mar 29, 2023

Conversation

jasonjoh
Copy link
Member

  • Deleted old docs
  • Created custom 404 page pointing users to our new docs page (preview)

@baywet
Copy link
Member

baywet commented Mar 29, 2023

Thanks for all your work on that front @jasonjoh QQ: have you reflected the changes of those two PRs in the new location? (I don't think we're changed anything since you moved the content)
#2406
#2451

Co-authored-by: Vincent Biret <[email protected]>
@jasonjoh
Copy link
Member Author

Thanks for all your work on that front @jasonjoh QQ: have you reflected the changes of those two PRs in the new location? (I don't think we're changed anything since you moved the content) #2406 #2451

Thanks for the reminder! I added these into this PR I'm currently working on:

https://github.com/MicrosoftDocs/openapi-docs-pr/pull/15

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a bunch of links in the main readme need to be updated.

@jasonjoh jasonjoh enabled auto-merge March 29, 2023 17:52
@jasonjoh
Copy link
Member Author

@baywet I just realized I did not copy over contributing.md to Learn. I'm not sure that content belongs in Learn. How do you feel about adding it back to the root of the repo?

@baywet
Copy link
Member

baywet commented Mar 29, 2023

@baywet I just realized I did not copy over contributing.md to Learn. I'm not sure that content belongs in Learn. How do you feel about adding it back to the root of the repo?

@jasonjoh it's usually a section of the readme. I'm not sure why we originally moved it to a separate page. But yes it should be on this repo and at the root. See an example

@jasonjoh
Copy link
Member Author

Yeah, I created a CONTRIBUTING.md and copied the content from the old one. It was more about required and recommended tools, and how to handle the submodule setup.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. I just removed the submodule instructions as we removed the submodule itself, it was generating too much noise

@jasonjoh jasonjoh merged commit e9ecaba into microsoft:main Mar 29, 2023
@jasonjoh jasonjoh deleted the gh-pages-retire branch July 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants