feature/private apis #1991
Merged
feature/private apis #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
added
the
generator
baywet
force-pushed
the
feature/private-apis
branch
2 times, most recently
from
dca5dda to
728f875
Compare
baywet
requested review from
andrueastman,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc,
ramsessanchez,
calebkiage,
Ndiritu and
rkodev
as code owners
auto-merge was automatically disabled
November 29, 2022 21:13
Pull request was converted to draft
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
- adds sign-in hints Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
- adds status message for logout command Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
- uses required keyword for options Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
baywet
force-pushed
the
feature/private-apis
branch
from
8b6a6db to
add6960
Compare
andrueastman
reviewed
Dec 1, 2022
src/Kiota.Builder/SearchProviders/GitHub/Authentication/PatAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
src/Kiota.Web/Authentication/GitHub/BrowserAccessTokenProvider.cs
Outdated
Show resolved
Hide resolved
src/kiota/Authentication/GitHub/DeviceCode/AcessTokenProvider.cs
Outdated
Show resolved
Hide resolved
src/Kiota.Builder/SearchProviders/GitHub/Authentication/TempFolderStorageService.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Eastman <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1983
Note for reviewers: the coverage is low because I added a lot of command handlers and we're currently not testing those.
Also, you can skip anything under
src/Kiota.Builder/SearchProviders/GitHub/GitHubClient/as it's generated.