Follow up to #1901 #1904
Merged
Follow up to #1901 #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrueastman
requested review from
baywet,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc,
ramsessanchez,
calebkiage,
Ndiritu and
rkodev
as code owners
baywet
requested changes
Oct 18, 2022
baywet
approved these changes
Oct 18, 2022
|
Kudos, SonarCloud Quality Gate passed! |
|
Thanks @baywet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #1901
It fixes an edge case where a type that is similar to a file extension exists in the reference input file that would cause generation to fail. Example is
microsoft.graph.json.This PR updates the
GetClassNamefunction to apply the extension exclusions if we have more than one segment in the name.