Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds host and scheme validation for access token providers #1051

Merged
merged 15 commits into from
Jan 31, 2022
Merged

adds host and scheme validation for access token providers #1051

merged 15 commits into from
Jan 31, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented Jan 21, 2022

fixes #1009

@baywet baywet added this to the TypeWriter Replacement milestone Jan 21, 2022
@baywet baywet added Go Java TypeScript Pull requests that update Javascript code Csharp Pull requests that update .net code labels Jan 21, 2022
@baywet baywet self-assigned this Jan 21, 2022
@baywet baywet requested a review from nikithauc January 24, 2022 15:19
@baywet baywet mentioned this pull request Jan 24, 2022
Closed
Base automatically changed from feature/go-and-java-auth-int-split to enhancement/nikithauc-authentication-encapsulation January 25, 2022 20:50
@baywet baywet mentioned this pull request Jan 25, 2022
Merged
@baywet
Copy link
Member Author

baywet commented Jan 26, 2022

@andrueastman would you mind pushing the similar changes for dotnet on this one please?

@baywet baywet force-pushed the feature/valid-hostnames branch from 32e01f9 to c1e9ce1 Compare January 26, 2022 18:02
@baywet baywet marked this pull request as ready for review January 26, 2022 18:04
@baywet @Ndiritu
Update abstractions/java/lib/src/main/java/com/microsoft/kiota/authen…
9a3cedc 
…tication/BaseBearerTokenAuthenticationProvider.java

Co-authored-by: Philip Gichuhi <[email protected]>
@baywet baywet requested a review from Ndiritu January 31, 2022 15:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@baywet baywet mentioned this pull request Jan 31, 2022
Merged
@baywet baywet merged commit 84eb3f3 into enhancement/nikithauc-authentication-encapsulation Jan 31, 2022
@baywet baywet deleted the feature/valid-hostnames branch January 31, 2022 20:36
This was referenced Feb 1, 2022
Merged
Merged
Closed
@baywet baywet linked an issue Feb 10, 2022 that may be closed by this pull request
authentication providers should check for valid hostnames before adding anything #1009
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndiritu Ndiritu Ndiritu approved these changes

@nikithauc nikithauc nikithauc approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@zengin zengin Awaiting requested review from zengin

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees

@baywet baywet

Labels
Csharp Pull requests that update .net code Go Java TypeScript Pull requests that update Javascript code
Projects
Kiota
Archived in project
Milestone
TypeWriter Replacement
Development

Successfully merging this pull request may close these issues.

authentication providers should check for valid hostnames before adding anything
4 participants
@baywet @andrueastman @Ndiritu @nikithauc