Apply suggestions from code review

Co-authored-by: Eastman <[email protected]>
microsoft · Dec 1, 2022 · 58a82e8 · 58a82e8
1 parent add6960
commit 58a82e8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/src/Kiota.Builder/SearchProviders/GitHub/Authentication/PatAuthenticationProvider.cs b/src/Kiota.Builder/SearchProviders/GitHub/Authentication/PatAuthenticationProvider.cs
@@ -7,7 +7,7 @@ namespace Kiota.Builder.SearchProviders.GitHub.Authentication;
 public class PatAuthenticationProvider : BaseAuthenticationProvider<PatAccessTokenProvider>
 {
     public PatAuthenticationProvider(string clientId, string scope, IEnumerable<string> validHosts, ILogger logger, ITokenStorageService StorageService) :
-        base(clientId, scope, validHosts, logger, (clientId, scope, validHosts) => new PatAccessTokenProvider {
+        base(clientId, scope, validHosts, logger, (_, _, validHosts) => new PatAccessTokenProvider {
             StorageService = StorageService,
             AllowedHostsValidator = new (validHosts),
         }, false)

diff --git a/src/Kiota.Builder/SearchProviders/GitHub/Authentication/TempFolderStorageService.cs b/src/Kiota.Builder/SearchProviders/GitHub/Authentication/TempFolderStorageService.cs
@@ -47,7 +47,7 @@ public async Task<bool> IsTokenPresentAsync(CancellationToken cancellationToken)
             if (!File.Exists(target))
                 return false;
             var fileDate = File.GetLastWriteTime(target);
-            if(fileDate > DateTime.Now.AddMonths(6)) {
+            if(fileDate > DateTime.Now.AddMonths(-6)) {
                 await DeleteTokenAsync(cancellationToken);
                 return false;
             }

diff --git a/src/Kiota.Web/Authentication/GitHub/BrowserAccessTokenProvider.cs b/src/Kiota.Web/Authentication/GitHub/BrowserAccessTokenProvider.cs
@@ -51,8 +51,7 @@ private Uri GetAuthorizeUrl(Guid state) {
 		tokenRequest.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
 		using var tokenResponse = await HttpClient.SendAsync(tokenRequest, cancellationToken);
 		tokenResponse.EnsureSuccessStatusCode();
-		var tokenContent = await tokenResponse.Content.ReadAsStringAsync(cancellationToken);
-		var result = JsonSerializer.Deserialize<AccessCodeResponse>(tokenContent);
+		var result = await tokenResponse.Content.ReadFromJsonAsync<AccessCodeResponse>(cancellationToken:cancellationToken);
 		if ("authorization_pending".Equals(result?.Error, StringComparison.OrdinalIgnoreCase))
 			return null;
 		else if (!string.IsNullOrEmpty(result?.Error))

diff --git a/src/kiota/Handlers/BaseKiotaCommandHandler.cs b/src/kiota/Handlers/BaseKiotaCommandHandler.cs
@@ -63,7 +63,7 @@ private IAuthenticationProvider GetGitHubPatAuthenticationProvider(ILogger logge
                                     new List<string> { Configuration.Search.GitHub.ApiBaseUrl.Host },
                                     logger,
                                     GetGitHubPatStorageService(logger));
-    protected async Task<KiotaSearcher> GetKiotaSearcher(ILoggerFactory loggerFactory, CancellationToken cancellationToken) {
+    protected async Task<KiotaSearcher> GetKiotaSearcherAsync(ILoggerFactory loggerFactory, CancellationToken cancellationToken) {
         var logger = loggerFactory.CreateLogger<KiotaSearcher>();
         var deviceCodeSignInCallback = GetIsGitHubDeviceSignedInCallback(logger);
         var patSignInCallBack = GetIsGitHubPatSignedInCallback(logger);