Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uri-template-lite breaks when using a bundler #584

Closed
andreaTP opened this issue Mar 30, 2023 · 1 comment · Fixed by #619
Closed

uri-template-lite breaks when using a bundler #584

andreaTP opened this issue Mar 30, 2023 · 1 comment · Fixed by #619
Assignees

Comments

@andreaTP
Copy link
Contributor

andreaTP commented Mar 30, 2023

Trying to use kiota-typescript from a UI application that is bundled using vite we have been experiencing issues with uri-template-lite.

unnamed

The current workaround is to exclude the package from the bundler:

  build: {
    ...
    rollupOptions: {
      external: ['uri-template-lite'],
    }
  },

but is less than ideal and it compromises the "getting started" experience.

We have various options here:

  • include the single source of uri-template-lite in this codebase
  • rely on a different library (that better plays with modules etc.)
  • open to other ideas!
@baywet baywet self-assigned this Mar 30, 2023
@baywet
Copy link
Member

baywet commented Mar 30, 2023

Thanks for reporting this. 4th option, PR them so this dependency supports that scenario as well.
Especially since there are a number of RedHat projects that depend on it.
Do you think you could get somebody, or yourself to fix that aspect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants