Bump uri template

[andreaTP]

This should fix #584 , I couldn't verify that this completely solves the problem but is a good guess ...

[baywet]

Thanks for the contribution as always.
We use yarn here and lerna, would you mind dropping the package lock and running a yarn install for sanity please? Also left a couple of comments.

[baywet]

@koros for final review and testing in a browser setup + in a node app setup

[andreaTP]

should be ready now 🙂

[andreaTP]

Rebased on latest main, @koros can you, please, trigger the CI? 🙏

[koros]

@andreaTP there's something else broken but it has nothing to do with this PR, its the generation side let me look into that.

[MIchaelMainer]

First off, thank you @andreaTP for your time and effort. We appreciate you.

Folks, we shouldn't be merging directly into the branch where we publish from. We should consider creating another branch off of main, create new PR into the branch, merge into that branch, and then the CI/CD can run when you create another PR into main. That way, the community contribution is counted and the CI is run.

[andreaTP]

Thanks for chipping in @MIchaelMainer !

Folks, we shouldn't be merging directly into the branch where we publish from.

This is not a common practice, but I have no objection if someone is willing to do the manual work all of the time ...

We should consider creating another branch off of main, create new PR into the branch, merge into that branch, and then the CI/CD can run when you create another PR into main.

This could work, but I expect it to work now as #668 got merged.

At the moment seems like something is broken in Kiota main and the test is correctly failing because of it.

[andreaTP]

Just to make it clear, the current CI failure doesn't seem to be related with the changes proposed in this PR.

[andreaTP]

@baywet sorry for bothering you directly, would you be able to facilitate the progress on this PR?

[baywet]

@andreaTP it seems our CI is impacted by this microsoft/kiota#2676 which makes it flaky. I just reran the thing for now and it passed.
Thank you for your patience while I was away. We'll need to investigate the generation behaviour, but that's a separate issue we've already captured.
Merging.

[ksdaniel]

Not sure this is related - but, with Vite and:

  "name": "@microsoft/kiota-abstractions",
  "version": "1.0.0-preview.19"

i get an exception:

Uncaught (in promise) TypeError: Template is not a constructor
    at get URL [as URL] (requestInformation.ts:42:24)
    at FetchRequestAdapter.<anonymous> (fetchRequestAdapter.js:452:45)

Looking at the packages for kiota-abstractions:

  "dependencies": {
    "@opentelemetry/api": "^1.2.0",
    "tinyduration": "^3.2.2",
    "tslib": "^2.3.1",
    "uri-template-lite": "^23.4.0",
    "uuid": "^9.0.0"
  },

we are on the new version of uri-template-lite.

But the code seems to break here:

 const template = new Template(this.urlTemplate);
          const data = {};

aka:

      const template = new (Template as any)(this.urlTemplate);

Got any ideas? This is a rather "blocking" issue.

[baywet]

Thanks for reporting this. Do you have the same issue if you downgrade the package?

[ksdaniel]

If I downgrade to

    "@microsoft/kiota-abstractions": "1.0.0-preview.18",
    "@microsoft/kiota-http-fetchlibrary": "^1.0.0-preview.18",
    "@microsoft/kiota-serialization-form": "^1.0.0-preview.8",
    "@microsoft/kiota-serialization-json": "^1.0.0-preview.17",
    "@microsoft/kiota-serialization-text": "^1.0.0-preview.16",

I no longer see the error, mentioned before. (I only downgraded kiota-abstractions)

But now there seems to be a mismatch between kiota-abstractions and kiota-http-fetchlibrary and I get different errors.

Any idea what the working combination might be?

[ksdaniel]

Just an update - in the end, this combination ran for me:

    "@microsoft/kiota-abstractions": "1.0.0-preview.18",
    "@microsoft/kiota-http-fetchlibrary": "1.0.0-preview.17",
    "@microsoft/kiota-serialization-form": "1.0.0-preview.7",
    "@microsoft/kiota-serialization-json": "1.0.0-preview.16",
    "@microsoft/kiota-serialization-text": "1.0.0-preview.15",

Able to compile and bundle with Vite - the definition mismatches are also gone.

[andreaTP]

@ksdaniel would you be able to provide a minimal reproducer so that we can fix the underlying issue?