WriteAdditionalData Code Cleanup #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dadams39
commented
Jun 22, 2022
dadams39
commented
- Initial look at adding maps to the writer to support mapping of Primitive types.
- General code clean-up to add a switch statement
- Initial look at adding maps to writer for primative types
dadams39
requested review from
andrueastman,
baywet,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc,
ramsessanchez and
calebkiage
as code owners
NOTEThe original code had this unreachable code: because of -> The endpoints for the clauses are different. This was one of the major reasons for the code restructure. The other was to ensure that trusted functions which were already created could be reused. |
|
Thanks for submitting this pull request. Review on hold until #30 is fixed |
Changes ensure that the collections are properly deliminated and map support for @odata.type --> microsoft.graph.eventMessageRequest
Test case extended to ensure support for microsoft.graph.eventMessageResponse
dadams39
commented
Jun 28, 2022
5 tasks
|
STATUS |
As per the agreement within the Issue, mapping capability has been removed until further notice. Test suites adjusted accordingly.
|
Status: |
baywet
requested changes
Jun 28, 2022
baywet
requested changes
Jun 29, 2022
baywet
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.