Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- fixes a bug where new lines in string value would produce invalid JSON #26

Merged
merged 1 commit into from
Jun 10, 2022
Merged

- fixes a bug where new lines in string value would produce invalid JSON #26

merged 1 commit into from
Jun 10, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented Jun 9, 2022

fixes #24

@baywet baywet self-assigned this Jun 9, 2022
@baywet baywet requested a review from calebkiage as a code owner June 9, 2022 14:59
@baywet baywet enabled auto-merge June 9, 2022 14:59
@baywet baywet mentioned this pull request Jun 9, 2022
Closed
@dadams39
Copy link
Contributor

dadams39 commented Jun 10, 2022 •
edited
Loading

Verifying the error In branch wait for update

@dadams39
Copy link
Contributor

dadams39 commented Jun 10, 2022 •
edited
Loading

The main's handling prior to merging:

* AAMkAGQ1NzViZTdhLTEwMTMtNGJjNi05YWI2L.....A=: unsupported AdditionalData type: map[string]*jsonserialization.JsonParseNode

In the bugfix/newlines branch, using the data retrieved from Graph Explorer verified -> PASS: TestNewFailure (0.00s)
Ready to merge based on my tests.

@dadams39 dadams39 mentioned this pull request Jun 10, 2022
Closed
5 tasks
@baywet baywet merged commit e5b31bc into main Jun 10, 2022
@baywet baywet deleted the bugfix/newlines branch June 10, 2022 20:24
@baywet
Copy link
Member Author

baywet commented Jun 20, 2022

@dadams39 thanks for your patience on the late release, I was out sick last week. This is now released as 0.5.3

@dadams39 dadams39 mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@calebkiage calebkiage Awaiting requested review from calebkiage

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unsupported AdditionalData type: map[string]*jsonserialization.JsonParseNode Write Object
3 participants
@baywet @dadams39 @MIchaelMainer