Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes the responseHandler to be a requestOption #41

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Changes the responseHandler to be a requestOption #41

merged 1 commit into from
Oct 17, 2022

Conversation

andrueastman
Copy link
Member

This PR is part of microsoft/kiota#1858

Changes include : -

  • Updates Send* methods in IRequestAdapter to move the responseHanlderParameter
  • Adds the SetResponseHandler method to be able to directly add IResposeHandler to a request
  • Adds the GetRequestOption<T> method to be able to get an IRequestOption instance by the type in O(1) time.
  • Adds tests to validate

This was referenced Oct 17, 2022
Merged
Merged
Merged
@andrueastman andrueastman marked this pull request as ready for review October 17, 2022 10:28
@andrueastman andrueastman merged commit 9b53254 into main Oct 17, 2022
@andrueastman andrueastman deleted the ResponseHanlderChanges branch October 17, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet