forked from facebook/hermes
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds in default Intl.DateTimeFormat #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@TatianaKapos, just FYI: I had fixed the CodeFlow link in the description. |
vmoroz
reviewed
Sep 9, 2022
vmoroz
reviewed
Sep 9, 2022
vmoroz
reviewed
Sep 9, 2022
vmoroz
reviewed
Sep 9, 2022
vmoroz
reviewed
Sep 9, 2022
vmoroz
reviewed
Sep 9, 2022
vmoroz
reviewed
Sep 9, 2022
vmoroz
reviewed
Sep 10, 2022
vmoroz
reviewed
Sep 10, 2022
vmoroz
reviewed
Sep 10, 2022
vmoroz
reviewed
Sep 10, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Sep 20, 2022
mganandraj
reviewed
Oct 13, 2022
mganandraj
reviewed
Nov 8, 2022
mganandraj
reviewed
Nov 8, 2022
mganandraj
reviewed
Nov 8, 2022
mganandraj
reviewed
Nov 8, 2022
mganandraj
reviewed
Nov 20, 2022
mganandraj
reviewed
Nov 20, 2022
mganandraj
reviewed
Nov 20, 2022
mganandraj
approved these changes
Nov 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manuelpuyol
added a commit
to manuelpuyol/hermes
that referenced
this pull request
Mar 22, 2024
See microsoft#127 This implements format, supportedLocalesOf and resolvedOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds in a basic Intl.DateTimeFormat, see https://tc39.es/ecma402/#datetimeformat-objects. This DateTimeFormat has all the options but dayPeriod and more work is required to fully meet ECMA402 specification.
Takes a lot of code/functions/styling from apples current implementation (https://github.com/facebook/hermes/blob/main/lib/Platform/Intl/PlatformIntlApple.mm) and added them into a shared code file. You also won't get this change by default, you'll still need to set the HERMES_ENABLE_INTL flag to ON.
Reason for Change
See #87. TDLR: start of work to adding windows support for the Intl APIs. Android already supports the Intl APIs while Apple has starting filling out their own implementation (facebook@150bf0e and beyond). We should follow suit as Hermes becomes the default engine for RNW and has already been asks for it.
Further work need to match ECMA402 specifications
Testing
Unit Tests included in PR and passing. Expected output matching when plugged into https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat

Current Status of test262.js files, since we only have DateTimeFormat implemented, I would expect a lot of these tests to fail

Microsoft Reviewers: Open in CodeFlow